RSDK-14012: Have FrameSystems walk frames/geometries to reset mesh caches.#6061
Open
dgottlieb wants to merge 1 commit into
Open
RSDK-14012: Have FrameSystems walk frames/geometries to reset mesh caches.#6061dgottlieb wants to merge 1 commit into
dgottlieb wants to merge 1 commit into
Conversation
viambot
added
the
safe to test
dgottlieb
commented
Jun 2, 2026
| request.StartState.structuredConfiguration, | ||
| ) | ||
| if err != nil { | ||
| logger.CDebugf(ctx, "resetMeshCaches: skipping robot geometries: %v", err) |
Member
Author
There was a problem hiding this comment.
This happens when the start state is out of bounds. And we won't return related geometries in those cases.
So I was worried we weren't clearing the cache in some cases when it was useful. But I now concluded this is fine? Because I expect this only gets hit when we never filled up the mesh cache?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.